[
https://issues.apache.org/jira/browse/HBASE-12596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615222#comment-14615222
]
Ted Yu commented on HBASE-12596:
--------------------------------
{code}
+ private static final String OUTPUT_TABLE_NAME_CONF_KEY =
+ "hbase.mapreduce.hfileoutputformat.output.table.name";
{code}
The '.output.' in above config key seems redundant since table name is for
hfileoutputformat.
{code}
+ if (null == loc) {
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("failed to get region location, so use default
writer");
{code}
Can you include rowKey in the above log ?
{code}
+ LOG.trace("failed to resolve of bind address: " +
loc.getHostname() + ":"
+ + loc.getPort() + ", so use default writer");
{code}
Remove ' of ' in log message.
{code}
+ private WriterLength getNewWriter(byte[] family, Configuration conf,
+ InetSocketAddress[] favoredNodes) throws IOException {
{code}
nit: Indentation is off for second line above.
> bulkload needs to follow locality
> ---------------------------------
>
> Key: HBASE-12596
> URL: https://issues.apache.org/jira/browse/HBASE-12596
> Project: HBase
> Issue Type: Improvement
> Components: HFile, regionserver
> Affects Versions: 0.98.8
> Environment: hadoop-2.3.0, hbase-0.98.8, jdk1.7
> Reporter: Victor Xu
> Assignee: Victor Xu
> Fix For: 0.98.14
>
> Attachments: HBASE-12596-0.98-v1.patch, HBASE-12596-0.98-v2.patch,
> HBASE-12596-0.98-v3.patch, HBASE-12596-master-v1.patch,
> HBASE-12596-master-v2.patch, HBASE-12596-master-v3.patch, HBASE-12596.patch
>
>
> Normally, we have 2 steps to perform a bulkload: 1. use a job to write HFiles
> to be loaded; 2. Move these HFiles to the right hdfs directory. However, the
> locality could be loss during the first step. Why not just write the HFiles
> directly into the right place? We can do this easily because
> StoreFile.WriterBuilder has the "withFavoredNodes" method, and we just need
> to call it in HFileOutputFormat's getNewWriter().
> This feature is enabled by default, and we could use
> 'hbase.bulkload.locality.sensitive.enabled=false' to disable it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
