[
https://issues.apache.org/jira/browse/HBASE-12596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616200#comment-14616200
]
Ashish Singhi commented on HBASE-12596:
---------------------------------------
{code}
+ try {
+ try (Connection connection =
ConnectionFactory.createConnection(conf);
+ RegionLocator locator =
+
connection.getRegionLocator(TableName.valueOf(tableName))) {
+ loc = locator.getRegionLocation(rowKey);
+ }
+ } catch (Throwable e) {
+ LOG.warn("there's something wrong when locating rowkey: " +
+ Bytes.toString(rowKey), e);
+ loc = null;
+ }
{code}
Why try block within another try ? Not required, you can remove the first one.
{code}
+ private static final String LOCALITY_SENSITIVE_CONF_KEY =
+ "hbase.bulkload.locality.sensitive.enabled";
{code}
Can you make this public and refer the same in test classes ?
Is it possible for you to add a test case where
{{hbase.bulkload.locality.sensitive.enabled}} is set to true ?
> bulkload needs to follow locality
> ---------------------------------
>
> Key: HBASE-12596
> URL: https://issues.apache.org/jira/browse/HBASE-12596
> Project: HBase
> Issue Type: Improvement
> Components: HFile, regionserver
> Affects Versions: 0.98.8
> Environment: hadoop-2.3.0, hbase-0.98.8, jdk1.7
> Reporter: Victor Xu
> Assignee: Victor Xu
> Fix For: 0.98.14
>
> Attachments: HBASE-12596-0.98-v1.patch, HBASE-12596-0.98-v2.patch,
> HBASE-12596-0.98-v3.patch, HBASE-12596-0.98-v4.patch,
> HBASE-12596-master-v1.patch, HBASE-12596-master-v2.patch,
> HBASE-12596-master-v3.patch, HBASE-12596-master-v4.patch, HBASE-12596.patch
>
>
> Normally, we have 2 steps to perform a bulkload: 1. use a job to write HFiles
> to be loaded; 2. Move these HFiles to the right hdfs directory. However, the
> locality could be loss during the first step. Why not just write the HFiles
> directly into the right place? We can do this easily because
> StoreFile.WriterBuilder has the "withFavoredNodes" method, and we just need
> to call it in HFileOutputFormat's getNewWriter().
> This feature is enabled by default, and we could use
> 'hbase.bulkload.locality.sensitive.enabled=false' to disable it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
