[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720761#comment-14720761
]
Enis Soztutar commented on HBASE-14261:
---------------------------------------
Thanks Srikanth. The patch looks almost there. Some more comments:
bq. Currently, zk nodes are being read using ZKServerTool and the actions get
triggered on those nodes pointed to by the output. Not sure what exactly was
being pointed to here.
Sorry I missed this part in the first patch.
This still prints to the System.out and creates a new Configuration. We want to
pass the conf and only print out to system.out when ZkServerTool.main() is
called.
{code}
+ public static ServerName[] readZKNodes() {
{code}
This should be ZOOKEEPER_SERVER since it is not a daemon of HBase.
{code}
HBASE_ZOOKEEPER("zookeeper")
{code}
Is there a way to ask NN the list of datanodes instead of reading {{slaves}}
file? In my deployment, the slaves files is under {{$HADOOP_CONF_DIR}}.
{code}
+ for (String line: FileUtils.readLines(new File(hadoopHome +
"/etc/hadoop/slaves"))) {
{code}
This should default to "hbase" rather than root:
{code}
+ return conf.get("hbase.it.clustermanager.hbase.user", "root");
{code}
In deployments I have seen, hdfs daemons and mapred daemons are run as
different users (hdfs and mapred typically). We are only interested in killing
hdfs datanodes for now. So maybe {{"hbase.it.clustermanager.hadoop.hdfs.user}}?
{code}
+ return conf.get("hbase.it.clustermanager.hadoop.user", "hadoop");
{code}
This does not belong in RemoteShell IMO. Passing the user directly is better.
{code}
+ private String getServiceUser() {
{code}
Better to sleep 100ms rather than 1sec.
{code}
+ Threads.sleep(1000);
{code}
Some lines are using 4 instead of 2 spaces as indentation.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> ---------------------------------------------------------------------------------
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
> Reporter: Srikanth Srungarapu
> Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch, HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
