[ 
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724710#comment-14724710
 ] 

Hadoop QA commented on HBASE-14261:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12753421/HBASE-14261-branch-1_v3.patch
  against branch-1 branch at commit 498c1845ab7b01710955153c27501fdc7492849d.
  ATTACHMENT ID: 12753421

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 30 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +        throw new IOException("Hadoop home configuration parameter i.e. 
'hbase.it.clustermanager.hadoop.home' " +
+        throw new IOException("Zookeeper home configuration parameter i.e. 
'hbase.it.clustermanager.zookeeper.home' " +
+  private Pair<Integer, String> exec(String hostname, ServiceType service, 
String... cmd) throws IOException {
+    String ret = execWithRetries(hostname, service, 
getCommandProvider(service).isRunningCommand(service))
+  public static final String KILL_ZK_NODE_TIMEOUT_KEY = 
"hbase.chaosmonkey.action.killzknodetimeout";
+  public static final String START_ZK_NODE_TIMEOUT_KEY = 
"hbase.chaosmonkey.action.startzknodetimeout";
+  public static final String KILL_DATANODE_TIMEOUT_KEY = 
"hbase.chaosmonkey.action.killdatanodetimeout";
+  public static final String START_DATANODE_TIMEOUT_KEY = 
"hbase.chaosmonkey.action.startdatanodetimeout";
+    killZkNodeTimeout = cluster.getConf().getLong(KILL_ZK_NODE_TIMEOUT_KEY, 
KILL_ZK_NODE_TIMEOUT_DEFAULT);
+    startZkNodeTimeout = cluster.getConf().getLong(START_ZK_NODE_TIMEOUT_KEY, 
START_ZK_NODE_TIMEOUT_DEFAULT);

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 4 zombie test(s):       
at 
org.apache.hadoop.hbase.security.access.TestCellACLs.testCoveringCheck(TestCellACLs.java:405)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15372//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15372//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15372//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15372//console

This message is automatically generated.

> Enhance Chaos Monkey framework by adding zookeeper and datanode fault 
> injections.
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-14261
>                 URL: https://issues.apache.org/jira/browse/HBASE-14261
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>         Attachments: HBASE-14261-branch-1.patch, 
> HBASE-14261-branch-1_v3.patch, HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault 
> injections for hbase dependencies like zookeeper, hdfs etc. This patch 
> attempts to solve this problem partially by adding datanode and zk node fault 
> injections.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to