[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726902#comment-14726902
]
Srikanth Srungarapu commented on HBASE-14261:
---------------------------------------------
bq. Any reason that DistributedHBaseCluster (and HBaseCluster) now has
waitForZkNodeToStart and waitForDataNodeToStart? I see that there were
previously just wait... methods for stopping, so I'm wondering if the wait
shouldn't just be implicit for starts (i.e. do we ever envision wanting to not
wait for the service to be started before doing things?).
We do have {{waitForRegionServerToStart}} and {{waitForActiveAndReadyMaster}}.
So, I followed the same pattern here too.
bq. Just as a general best practices question, in HBaseClusterManager, you
throw an IOException if hbase.it.clustermanager. {zookeeper,hadoop}.home isn't
set. Does not passing a correct config qualify as an IOException, or should
this just be a more general Exception?
I agree that IOException is not the most appropriate object to use here.
Hopefully HBASE-13936 will help us in handling misappropriate configurations
more appropriately. In the meanwhile, if you have something else in mind, I'd
be happy to incorporate into the patch.
Addressed all other issues in the latest patch.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> ---------------------------------------------------------------------------------
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
> Reporter: Srikanth Srungarapu
> Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
