[ https://issues.apache.org/jira/browse/HBASE-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143780#comment-13143780 ]
Phabricator commented on HBASE-4746: ------------------------------------ tedyu has commented on the revision "[jira] [HBASE-4746] [89-fb] Use a random ZK client port in unit tests so we can run them in parallel". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/MiniZooKeeperCluster.java:64 How was 0xc000 chosen ? src/main/java/org/apache/hadoop/hbase/MiniZooKeeperCluster.java:113 Should this be debug ? I imagine there would be many mini zookeeper clusters running in parallel on the build machine. src/main/java/org/apache/hadoop/hbase/client/HTable.java:90 Nice. We can mark this ctor deprecated in HBase 0.92. For HBase TRUNK, I think we should remove this ctor and the ctor on line 104. REVISION DETAIL https://reviews.facebook.net/D255 > Use a random ZK client port in unit tests so we can run them in parallel > ------------------------------------------------------------------------ > > Key: HBASE-4746 > URL: https://issues.apache.org/jira/browse/HBASE-4746 > Project: HBase > Issue Type: Improvement > Reporter: Mikhail Bautin > Attachments: D255.1.patch > > > The hard-coded ZK client port has long been a problem for running HBase test > suite in parallel. The mini ZK cluster should run on a random free port, and > that port should be passed to all parts of the unit tests that need to talk > to the mini cluster. In fact, randomizing the port exposes a lot of places in > the code where a new configuration is instantiated, and as a result the > client tries to talk to the default ZK client port and times out. > The initial fix is for 0.89-fb, where it already allows to run unit tests in > parallel in 10 minutes. A fix for the trunk will follow. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira