[
https://issues.apache.org/jira/browse/HBASE-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-4746:
-------------------------------
Attachment: D279.1.patch
mbautin requested code review of "[jira] [HBASE-4746] Use a random ZK client
port in unit tests so we can run them in parallel".
Reviewers: tedyu, JIRA
This is similar to D255 but for HBase trunk. Making ZK client port random and
fixing unit tests that fail because the port number is not being passed.
TEST PLAN
Run unit tests. Deploy on a dev cluster.
REVISION DETAIL
https://reviews.facebook.net/D279
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/HConstants.java
src/main/java/org/apache/hadoop/hbase/client/HTable.java
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java
src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java
src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java
src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
src/test/java/org/apache/hadoop/hbase/replication/TestMasterReplication.java
src/test/java/org/apache/hadoop/hbase/replication/TestMultiSlaveReplication.java
src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java
src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java
src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitter.java
src/test/java/org/apache/hadoop/hbase/zookeeper/TestHQuorumPeer.java
src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/525/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Use a random ZK client port in unit tests so we can run them in parallel
> ------------------------------------------------------------------------
>
> Key: HBASE-4746
> URL: https://issues.apache.org/jira/browse/HBASE-4746
> Project: HBase
> Issue Type: Improvement
> Reporter: Mikhail Bautin
> Attachments: D255.1.patch, D279.1.patch
>
>
> The hard-coded ZK client port has long been a problem for running HBase test
> suite in parallel. The mini ZK cluster should run on a random free port, and
> that port should be passed to all parts of the unit tests that need to talk
> to the mini cluster. In fact, randomizing the port exposes a lot of places in
> the code where a new configuration is instantiated, and as a result the
> client tries to talk to the default ZK client port and times out.
> The initial fix is for 0.89-fb, where it already allows to run unit tests in
> parallel in 10 minutes. A fix for the trunk will follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
