[ 
https://issues.apache.org/jira/browse/HBASE-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144912#comment-13144912
 ] 

Ted Yu commented on HBASE-4746:
-------------------------------

@Mikhail:
Thanks for working overtime for producing TRUNK patch.

ThriftHBaseServiceHandler originally uses the default ctor (generated by 
compiler) which doesn't take Configuration.
The addition of new ctor hides that default ctor and results in:
{code}
[ERROR] 
/Users/zhihyu/trunk-hbase/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java:[199,36]
 cannot find symbol
[ERROR] symbol  : constructor ThriftHBaseServiceHandler()
[ERROR] location: class 
org.apache.hadoop.hbase.thrift2.ThriftHBaseServiceHandler
{code}
I went over thrift2/ThriftServer.java and didn't find an easy way of plugging 
in Configuration parameter.

I suggest adding the argument-less ctor for ThriftHBaseServiceHandler.
                
> Use a random ZK client port in unit tests so we can run them in parallel
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4746
>                 URL: https://issues.apache.org/jira/browse/HBASE-4746
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>         Attachments: D255.1.patch, D279.1.patch
>
>
> The hard-coded ZK client port has long been a problem for running HBase test 
> suite in parallel. The mini ZK cluster should run on a random free port, and 
> that port should be passed to all parts of the unit tests that need to talk 
> to the mini cluster. In fact, randomizing the port exposes a lot of places in 
> the code where a new configuration is instantiated, and as a result the 
> client tries to talk to the default ZK client port and times out.
> The initial fix is for 0.89-fb, where it already allows to run unit tests in 
> parallel in 10 minutes. A fix for the trunk will follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to