[
https://issues.apache.org/jira/browse/HBASE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144786#comment-13144786
]
Phabricator commented on HBASE-4742:
------------------------------------
Liyin has commented on the revision "[jira] [HBASE-4742] Split dead server's
log in parallel".
Answer the comments inline.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:312 I
agree with Ted.
The thread number is bounded by the number of dead servers at one time
naturally.
Prakash, what do you think?
src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:333
Why do you think it is NOT OK ???
src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:337
What' wrong with "Succeed to split" ?
src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:347-348
I believe it is more reasonable to throw RuntimeExcpetion.
src/test/java/org/apache/hadoop/hbase/master/TestMultiRegionServerShutDown.java:135
I try to ignore this Exception here on purpose.
REVISION DETAIL
https://reviews.facebook.net/D237
> Split dead server's log in parallel
> -----------------------------------
>
> Key: HBASE-4742
> URL: https://issues.apache.org/jira/browse/HBASE-4742
> Project: HBase
> Issue Type: Improvement
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D237.1.patch, D237.2.patch, D237.3.patch, D237.4.patch
>
>
> When one region server goes down, the master will shutdown the region server
> and split its log.
> However, splitting log is a blocking call and it would take some time.
> If more than one region server go down, the master will split its log one by
> one, which is not efficient.
> Since we have the distributed log split, we could split these logs from the
> dead servers in parallel.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
