[ 
https://issues.apache.org/jira/browse/HBASE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144889#comment-13144889
 ] 

Phabricator commented on HBASE-4742:
------------------------------------

Liyin has commented on the revision "[jira] [HBASE-4742] Split dead server's 
log in parallel".

  Kannan, Mikhail, Prakash and Ted,
  How about batch all the dead servers in a blocking queue and only launch one 
thread in HMaster to distributed log splitting these dead regions together.

  The interface of distributed log splitting is:
  public void splitLog(final List<String> serverNames) {}
  So it naturally designed to split a list region servers.

  The reason I proposed this idea is because the function to split log in 
HMaster is not well-tested in a multithread situations.
  It may involve some race condition when 2 threads are going to distributed 
log splitting for 2 different dead region servers.

  If the master split dead servers log in batch in a single thread, then we can 
avoid these potential problems and also matches our original motivations.

  What do you guys think?

  Thanks
  Liyin



REVISION DETAIL
  https://reviews.facebook.net/D237

                
> Split dead server's log in parallel
> -----------------------------------
>
>                 Key: HBASE-4742
>                 URL: https://issues.apache.org/jira/browse/HBASE-4742
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Assignee: Liyin Tang
>         Attachments: D237.1.patch, D237.2.patch, D237.3.patch, D237.4.patch
>
>
> When one region server goes down, the master will shutdown the region server 
> and split its log.
> However, splitting log is a blocking call and it would take some time.
> If more than one region server go down, the master will split its log one by 
> one, which is not efficient.
> Since we have the distributed log split, we could split these logs from the 
> dead servers in parallel. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to