[
https://issues.apache.org/jira/browse/HBASE-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145116#comment-13145116
]
Phabricator commented on HBASE-4746:
------------------------------------
stack has accepted the revision "[jira] [HBASE-4746] [89-fb] Use a random ZK
client port in unit tests so we can run them in parallel".
Very nice Mikhail. Minor nits. Please attach patch to JIRA so we can
commit. If you have a moment, perhaps address the above else we'll do it on
commit. Good stuff.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/MiniZooKeeperCluster.java:113 I'd think
this log message rare since the port randomly chosen. When it does happen, I
think it should be noticeable so I'm fine w/ INFO. DEBUG would work too.
src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java:142 Good
src/main/java/org/apache/hadoop/hbase/client/HTable.java:90 +1
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java:200 Deprecate?
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:46 Why avro
package stuff in here?
src/test/resources/hbase-site.xml:128 Good catch.
REVISION DETAIL
https://reviews.facebook.net/D255
> Use a random ZK client port in unit tests so we can run them in parallel
> ------------------------------------------------------------------------
>
> Key: HBASE-4746
> URL: https://issues.apache.org/jira/browse/HBASE-4746
> Project: HBase
> Issue Type: Improvement
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: 4746-trunk-v2.txt, D255.1.patch, D279.1.patch,
> D279.2.patch
>
>
> The hard-coded ZK client port has long been a problem for running HBase test
> suite in parallel. The mini ZK cluster should run on a random free port, and
> that port should be passed to all parts of the unit tests that need to talk
> to the mini cluster. In fact, randomizing the port exposes a lot of places in
> the code where a new configuration is instantiated, and as a result the
> client tries to talk to the default ZK client port and times out.
> The initial fix is for 0.89-fb, where it already allows to run unit tests in
> parallel in 10 minutes. A fix for the trunk will follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
