[
https://issues.apache.org/jira/browse/HBASE-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145113#comment-13145113
]
Lars Hofhansl commented on HBASE-4746:
--------------------------------------
+1 on D279.2. Thanks for doing this Mikhail.
{code}
public int getRandomPort() {
return 0xc000 + new Random().nextInt(0x3f00);
}
{code}
Could use a comment on the choice of values.
Why did the statics have to be removed from TestMasterReplication but not from
TestReplication and TestMultislaveReplication (and I do apologize for the
cut-and-pasting here)?
> Use a random ZK client port in unit tests so we can run them in parallel
> ------------------------------------------------------------------------
>
> Key: HBASE-4746
> URL: https://issues.apache.org/jira/browse/HBASE-4746
> Project: HBase
> Issue Type: Improvement
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: 4746-trunk-v2.txt, D255.1.patch, D279.1.patch,
> D279.2.patch
>
>
> The hard-coded ZK client port has long been a problem for running HBase test
> suite in parallel. The mini ZK cluster should run on a random free port, and
> that port should be passed to all parts of the unit tests that need to talk
> to the mini cluster. In fact, randomizing the port exposes a lot of places in
> the code where a new configuration is instantiated, and as a result the
> client tries to talk to the default ZK client port and times out.
> The initial fix is for 0.89-fb, where it already allows to run unit tests in
> parallel in 10 minutes. A fix for the trunk will follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
