[
https://issues.apache.org/jira/browse/HBASE-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-4746:
-------------------------------
Attachment: D255.2.patch
mbautin updated the revision "[jira] [HBASE-4746] [89-fb] Use a random ZK
client port in unit tests so we can run them in parallel".
Reviewers: Kannan, Karthik, nspiegelberg, JIRA, stack
Making this diff more consistent with D279, and addressing Ted's and Miguel's
comments. The only unit tests that fail are TestReplication,
TestFullLogReconstruction, and TestZooKeeper, but these failures have existed
for a while and Liyin is working on a fix for those. The time to run the test
suite is consistently under 10 minutes.
REVISION DETAIL
https://reviews.facebook.net/D255
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/HConstants.java
src/main/java/org/apache/hadoop/hbase/MiniZooKeeperCluster.java
src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java
src/main/java/org/apache/hadoop/hbase/client/HTable.java
src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java
src/main/java/org/apache/hadoop/hbase/master/HMaster.java
src/main/java/org/apache/hadoop/hbase/master/ThrottledRegionReopener.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperWrapper.java
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java
src/main/ruby/hbase/admin.rb
src/test/java/org/apache/hadoop/hbase/HBaseClusterTestCase.java
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
src/test/java/org/apache/hadoop/hbase/TestFullLogReconstruction.java
src/test/java/org/apache/hadoop/hbase/TestMultiParallelPut.java
src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
src/test/java/org/apache/hadoop/hbase/avro/TestAvroServer.java
src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
src/test/java/org/apache/hadoop/hbase/loadtest/RegionSplitter.java
src/test/java/org/apache/hadoop/hbase/mapred/TestLegacyTableMapReduce.java
src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java
src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java
src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
src/test/java/org/apache/hadoop/hbase/master/TestRegionManager.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionClose.java
src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java
src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
src/test/java/org/apache/hadoop/hbase/rest/HBaseRESTClusterTestBase.java
src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteTable.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/test/java/org/apache/hadoop/hbase/zookeeper/TestHQuorumPeer.java
src/test/resources/hbase-site.xml
src/test/ruby/shell/shell_test.rb
> Use a random ZK client port in unit tests so we can run them in parallel
> ------------------------------------------------------------------------
>
> Key: HBASE-4746
> URL: https://issues.apache.org/jira/browse/HBASE-4746
> Project: HBase
> Issue Type: Improvement
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: 4746-trunk-v2.txt, D255.1.patch, D255.2.patch,
> D279.1.patch, D279.2.patch, D279.3.patch
>
>
> The hard-coded ZK client port has long been a problem for running HBase test
> suite in parallel. The mini ZK cluster should run on a random free port, and
> that port should be passed to all parts of the unit tests that need to talk
> to the mini cluster. In fact, randomizing the port exposes a lot of places in
> the code where a new configuration is instantiated, and as a result the
> client tries to talk to the default ZK client port and times out.
> The initial fix is for 0.89-fb, where it already allows to run unit tests in
> parallel in 10 minutes. A fix for the trunk will follow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
