[
https://issues.apache.org/jira/browse/HBASE-15205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150043#comment-15150043
]
ramkrishna.s.vasudevan commented on HBASE-15205:
------------------------------------------------
bq.Yeah, so you are adding to WALEntry the scopes Map but it is in WALKey
already?
Ya it is there already. Am just renaming it now.
bq.The WAL subsystem looks for them else falls back on old way of getting
scopes? Thats a bit hacky maybe.
Creating the scope and setting on the HTD key/value pair. What should be the
key name? Should it be the CF name? Later some tthing else can be added in the
key/value pair as the Cf name? Am not very sure how neat it would look if we
do that way.
bq.You are breaking WALActionsListener?
No. I verified it is IA.private. So should not be a problem.
bq.Adding method in Region interface seems not so good.
So better we will add only in HRegion and do the typecast where we are using
it? May be check for instanceof HRegion and do this if not fallback to the old
code?
> Do not find the replication scope for every WAL#append()
> --------------------------------------------------------
>
> Key: HBASE-15205
> URL: https://issues.apache.org/jira/browse/HBASE-15205
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15205.patch, HBASE-15205_1.patch,
> HBASE-15205_2.patch, HBASE-15205_3.patch, ScopeWALEdits.jpg,
> ScopeWALEdits_afterpatch.jpg
>
>
> After the byte[] and char[] the other top contributor for lot of GC (though
> it is only 2.86%) is the UTF_8.newDecoder.
> This happens because for every WAL append we try to calculate the replication
> scope associate with the families associated with the TableDescriptor. I
> think per WAL append doing this is very costly and creates lot of garbage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
