[
https://issues.apache.org/jira/browse/HBASE-15205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150851#comment-15150851
]
stack commented on HBASE-15205:
-------------------------------
The checkstyle and EOL complaints looks fixable. The failure is a common flakey
fail (@busbey... it just says TestHRegion failed. Any chance of adding which
test in TestHRegion failed, at least until support for seeing the jdk1.8 test
logs?)
bq. What should be the key name? Should it be the CF name?
There is convention for naming of keys used internally only. IIRC, you prefix
with an '_'.
bq. No. I verified it is IA.private. So should not be a problem.
Good.
>From above review and still prevalent in v4 of the patch: "Sometimes you use
>getScopes. Other times you use this.replicationScopes." Use the method always
>I'd say.
If this is used by Region only, why is it public:
public NavigableMap<byte[], Integer> getReplicationScope() {
Package private?
>From previous review, FSWALEntry has repilcation scopes added by this patch.
>You seem to be duplicating scopes by adding to WALEdit replication scopes
>again? i.e. A FSWALEntry has scopes recorded twice... once in FSWALEntry, and
>then again in WALKey?
In WALKey, can this be package private 421 public NavigableMap<byte[],
Integer> getReplicationScopes() {
> Do not find the replication scope for every WAL#append()
> --------------------------------------------------------
>
> Key: HBASE-15205
> URL: https://issues.apache.org/jira/browse/HBASE-15205
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15205.patch, HBASE-15205_1.patch,
> HBASE-15205_2.patch, HBASE-15205_3.patch, HBASE-15205_4.patch,
> ScopeWALEdits.jpg, ScopeWALEdits_afterpatch.jpg
>
>
> After the byte[] and char[] the other top contributor for lot of GC (though
> it is only 2.86%) is the UTF_8.newDecoder.
> This happens because for every WAL append we try to calculate the replication
> scope associate with the families associated with the TableDescriptor. I
> think per WAL append doing this is very costly and creates lot of garbage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
