[
https://issues.apache.org/jira/browse/HBASE-15205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152809#comment-15152809
]
stack commented on HBASE-15205:
-------------------------------
bq. Anyway I can remove it.
Thanks for rename, but yeah, if a public method can be removed on audience
private class, thats better.
bq. Hence passing on the replicationScope to the WALKey thro FSWALEntry seems
fine to me.
bq. So you want me to change in such a way that during WALKey construction
itself pass the replicationScope?
My problem is with our having two sets of scopes, one in WALKey and another in
WALEnry. There should be one set only.
So, you think passing replications scopes through to WALKey the way to go? It
already has scopes so makes sense?
bq. Before updating the next patch you still want me to go with the way of
setting the scope on HTD and use the same HTD to retrive the scope per family?
Above was a suggestion. Do what you think makes most sense. If scopes are to be
carried by the WalKey, in WAL#append, you don't have to take away the HTD to
replace it with map of scopes? They'll be in the WALKey when it is constructed?
bq. But I fear it wont serve the purpose of short living objects because the
HTD.setValue() will convert things to Bytes.
Good point. That makes my suggestion silly.
Thanks Ram.
> Do not find the replication scope for every WAL#append()
> --------------------------------------------------------
>
> Key: HBASE-15205
> URL: https://issues.apache.org/jira/browse/HBASE-15205
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15205.patch, HBASE-15205_1.patch,
> HBASE-15205_2.patch, HBASE-15205_3.patch, HBASE-15205_4.patch,
> ScopeWALEdits.jpg, ScopeWALEdits_afterpatch.jpg
>
>
> After the byte[] and char[] the other top contributor for lot of GC (though
> it is only 2.86%) is the UTF_8.newDecoder.
> This happens because for every WAL append we try to calculate the replication
> scope associate with the families associated with the TableDescriptor. I
> think per WAL append doing this is very costly and creates lot of garbage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
