[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212981#comment-15212981
]
stack commented on HBASE-14920:
-------------------------------
A few notes on the patch
Is the comment right when it says we are going to compact memory in the cache?
698 * @return True if we prefer to keep the in-memory data compacted
699 * for this column family in the HRegionServer cache
The attribute is InMemoryCompaction so the method should be
setInMemoryCompaction, not setCompacted?
Should this be in our public API? getMemStoreClassName It is a little exotic to
expose? We only have one use for it at the moment... wait till more than one
before exposing it?
In HConstants I see this unused import:
import static org.apache.hadoop.hbase.io.hfile.BlockType.MAGIC_LENGTH;
Your editor is redoing imports which bloats your patch [~eshcar] See
IntegrationTestBigLinkedList, a one line change bloated to 30 by the redo of
import and ExecutorService which is just import moves.
I'll be back
> Compacting Memstore
> -------------------
>
> Key: HBASE-14920
> URL: https://issues.apache.org/jira/browse/HBASE-14920
> Project: HBase
> Issue Type: Sub-task
> Reporter: Eshcar Hillel
> Assignee: Eshcar Hillel
> Attachments: HBASE-14920-V01.patch, HBASE-14920-V02.patch
>
>
> Implementation of a new compacting memstore with non-optimized immutable
> segment representation
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
