[ 
https://issues.apache.org/jira/browse/HBASE-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234454#comment-15234454
 ] 

Sean Busbey commented on HBASE-15605:
-------------------------------------

Personally, I find annotations of non-public methods/members much easier to 
work with in the code base than FooUtil classes that move the code away. The 
former is just a logical extension of the fact that we rely on annotation at 
all for our API rather than java access modifiers. The later requires that 
folks learning the code base realize the util class is something they need to 
go look for.

But this is a longstanding habit in our code base, so don't let me hold up your 
committing. In the idealized future where I have more time I'll start a DISCUSS 
thread about moving us the other way.

Please fix the checkstyle errors on commit.

> Remove PB references from HCD and HTD for 2.0
> ---------------------------------------------
>
>                 Key: HBASE-15605
>                 URL: https://issues.apache.org/jira/browse/HBASE-15605
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15605.patch, HBASE-15605_1.patch, 
> HBASE-15605_2.patch, HBASE-15605_branch-1.patch
>
>
> This task is sub-task for HBASE-15174. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to