[
https://issues.apache.org/jira/browse/HBASE-15525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327849#comment-15327849
]
stack commented on HBASE-15525:
-------------------------------
Ok. That makes sense.
Isn't the close in closeAndPutbackBuffers redundant? Or just-in-case? Close
will have already been called? If so, then this method should be called release
or free or releaseResources instead to make it clear what is going on.
I think this new class along with the pool implementation has the possibility
of being generally useful in more than just the context here hence my fixation
on making sure it is clear about how it is to be used.
bq. * Note: This pool returns off heap ByteBuffers.
The above is configurable? Add an override constructor that allows setting it
I'd say.
I think the new name for the class is clearer about what it is.
Otherwise, this patch is great. Needs fat release note how you'd use it.
> OutOfMemory could occur when using BoundedByteBufferPool during RPC bursts
> --------------------------------------------------------------------------
>
> Key: HBASE-15525
> URL: https://issues.apache.org/jira/browse/HBASE-15525
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC
> Reporter: deepankar
> Assignee: Anoop Sam John
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-15525_V1.patch, HBASE-15525_V2.patch,
> HBASE-15525_V3.patch, HBASE-15525_V4.patch, HBASE-15525_V5.patch,
> HBASE-15525_WIP.patch, WIP.patch
>
>
> After HBASE-13819 the system some times run out of direct memory whenever
> there is some network congestion or some client side issues.
> This was because of pending RPCs in the RPCServer$Connection.responseQueue
> and since all the responses in this queue hold a buffer for cellblock from
> BoundedByteBufferPool this could takeup a lot of memory if the
> BoundedByteBufferPool's moving average settles down towards a higher value
> See the discussion here
> [HBASE-13819-comment|https://issues.apache.org/jira/browse/HBASE-13819?focusedCommentId=15207822&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15207822]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
