[ https://issues.apache.org/jira/browse/HBASE-15525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328996#comment-15328996 ]
Anoop Sam John commented on HBASE-15525: ---------------------------------------- Thanks Stack.. Ya I checked again. Seems we call close() already. I was thinking we are not always. Fine releaseResources sound a better name with clear indication of what it is doing. Will change. bq. The pool returns off heap BBs. bq.The above is configurable? Add an override constructor that allows setting it I'd say. Ya as of now The pool return only off heap BBs. We can take a boolean constructor arg to set it to return on heap also.. I thought of doing that when the need actually arise? But fine let me do in new version. > OutOfMemory could occur when using BoundedByteBufferPool during RPC bursts > -------------------------------------------------------------------------- > > Key: HBASE-15525 > URL: https://issues.apache.org/jira/browse/HBASE-15525 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC > Reporter: deepankar > Assignee: Anoop Sam John > Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-15525_V1.patch, HBASE-15525_V2.patch, > HBASE-15525_V3.patch, HBASE-15525_V4.patch, HBASE-15525_V5.patch, > HBASE-15525_WIP.patch, WIP.patch > > > After HBASE-13819 the system some times run out of direct memory whenever > there is some network congestion or some client side issues. > This was because of pending RPCs in the RPCServer$Connection.responseQueue > and since all the responses in this queue hold a buffer for cellblock from > BoundedByteBufferPool this could takeup a lot of memory if the > BoundedByteBufferPool's moving average settles down towards a higher value > See the discussion here > [HBASE-13819-comment|https://issues.apache.org/jira/browse/HBASE-13819?focusedCommentId=15207822&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15207822] -- This message was sent by Atlassian JIRA (v6.3.4#6332)