[ 
https://issues.apache.org/jira/browse/HBASE-16445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466227#comment-15466227
 ] 

Duo Zhang commented on HBASE-16445:
-----------------------------------

The sync implementation is based on the async implementation. The 
{{callBlockingMethod}} just uses a {{BlockingRpcCallback}} to call 
{{callMethod}}.

And I added the locking comment on top of AbstractRpcClient. Let me add some 
comments for the netty implementation.

{quote}
This means resuable?
{quote}

Yes, reusable.

> Refactor and reimplement RpcClient
> ----------------------------------
>
>                 Key: HBASE-16445
>                 URL: https://issues.apache.org/jira/browse/HBASE-16445
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16445-v1.patch, HBASE-16445-v2.patch, 
> HBASE-16445-v3.patch, HBASE-16445-v4.patch, HBASE-16445.patch
>
>
> There are lots of common logics between RpcClientImpl and AsyncRpcClient. We 
> should have much less code comparing to the current implementations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to