[
https://issues.apache.org/jira/browse/HBASE-16591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15477202#comment-15477202
]
Duo Zhang commented on HBASE-16591:
-----------------------------------
[~busbey] Let's move the discussion here
{quote}
We'll also need docker files on the older branches with the right JVMs.
{quote}
Do we really need to do this?
{code}
if [ -r "${COMPONENT}/dev-support/docker/Dockerfile" ]; then
YETUS_ARGS=(--dockerfile="${COMPONENT}/dev-support/docker/Dockerfile"
${YETUS_ARGS[@]})
fi
{code}
Currently we do not specific a docker file when running yetus since
'dev-support/docker/Dockerfile' does not exist, so I think we will just use the
default docker file when running pre commit for HBase? Then I think we only
need to overwrite the default docker file for master and just let the other
branches use the default docker file which means just left the docker file
unexists?
Thanks.
> Add a docker file only contains java 8 for running pre commit on master
> -----------------------------------------------------------------------
>
> Key: HBASE-16591
> URL: https://issues.apache.org/jira/browse/HBASE-16591
> Project: HBase
> Issue Type: Task
> Components: build
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Blocker
> Fix For: 2.0.0
>
>
> As described in YETUS-369, this is a workaround before YETUS-369 done.
> Hadoop's pre-commit has already been java 8 only, so I think we could just
> copy their docker file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
