[
https://issues.apache.org/jira/browse/HBASE-16591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478546#comment-15478546
]
Duo Zhang commented on HBASE-16591:
-----------------------------------
Seems fine. The default java is 1.8.0_101 and there is only one javac and
compile in the report.
{noformat}
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | reexec | 0m 3s | Docker mode activated.
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any
| | | | new or modified tests. Please justify
| | | | why no new tests are needed for this
| | | | patch. Also please list what manual
| | | | steps were performed to verify this
| | | | patch.
| +1 | mvninstall | 77m 13s | master passed
| +1 | compile | 0m 16s | master passed
| +1 | checkstyle | 2m 12s | master passed
| +1 | mvneclipse | 2m 29s | master passed
| +1 | findbugs | 0m 52s | master passed
| +1 | javadoc | 1m 7s | master passed
| +1 | mvninstall | 0m 18s | the patch passed
| +1 | compile | 0m 15s | the patch passed
| +1 | javac | 0m 15s | the patch passed
| +1 | checkstyle | 0m 20s | the patch passed
| +1 | mvneclipse | 0m 10s | the patch passed
| +1 | whitespace | 0m 0s | The patch has no whitespace issues.
| -1 | hadoopcheck | 44m 32s | The patch causes 10 errors with Hadoop
| | | | v2.4.0.
| +1 | hbaseprotoc | 0m 8s | the patch passed
| +1 | findbugs | 0m 58s | the patch passed
| +1 | javadoc | 0m 14s | the patch passed
| +1 | asflicense | 0m 19s | The patch does not generate ASF License
| | | | warnings.
| | | 189m 53s |
|| Subsystem || Report/Notes ||
============================================================================
| Docker | Client=1.12.1 Server=1.12.1 Image:yetus/hbase:9d55c22 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux ac76faf581d9 3.13.0-54-generic #91-Ubuntu SMP Tue May 26
19:15:08 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/zhangduo/hbase/code/dev-support/hbase-personality.sh |
| git revision | master / 9d55c22 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| modules | C: hbase-client U: hbase-client |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
============================================================================
============================================================================
Finished build.
============================================================================
============================================================================
{noformat}
[~busbey] Let me check the script of hadoop pre-commit to see how they deal
with the branch selection.
Thanks.
> Add a docker file only contains java 8 for running pre commit on master
> -----------------------------------------------------------------------
>
> Key: HBASE-16591
> URL: https://issues.apache.org/jira/browse/HBASE-16591
> Project: HBase
> Issue Type: Task
> Components: build
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Blocker
> Fix For: 2.0.0
>
>
> As described in YETUS-369, this is a workaround before YETUS-369 done.
> Hadoop's pre-commit has already been java 8 only, so I think we could just
> copy their docker file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
