[ 
https://issues.apache.org/jira/browse/HBASE-16591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15479866#comment-15479866
 ] 

Duo Zhang commented on HBASE-16591:
-----------------------------------

In the docker file added in the patch above, we have installed 
protobuf-compiler.

{noformat}
RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
    build-essential \
    bzip2 \
    cmake \
    curl \
    doxygen \
    fuse \
    g++ \
    gcc \
    git \
    gnupg-agent \
    make \
    libbz2-dev \
    libcurl4-openssl-dev \
    libfuse-dev \
    libprotobuf-dev \
    libprotoc-dev \
    libsnappy-dev \
    libssl-dev \
    libtool \
    pinentry-curses \
    pkg-config \
    protobuf-compiler \
    protobuf-c-compiler \
    python \
    python2.7 \
    python-pip \
    rsync \
    snappy \
    zlib1g-dev
{noformat}

And for ubuntu trusty(14.04), the default version is '2.5.0-9ubuntu1', which is 
the right version for us.
https://launchpad.net/ubuntu/trusty/+package/protobuf-compiler

So let's commit this and try a pre-commit build of HBASE-15624 again? [~busbey]

Thanks.

> Add a docker file only contains java 8 for running pre commit on master
> -----------------------------------------------------------------------
>
>                 Key: HBASE-16591
>                 URL: https://issues.apache.org/jira/browse/HBASE-16591
>             Project: HBase
>          Issue Type: Task
>          Components: build
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16591.patch
>
>
> As described in YETUS-369, this is a workaround before YETUS-369 done. 
> Hadoop's pre-commit has already been java 8 only, so I think we could just 
> copy their docker file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to