[
https://issues.apache.org/jira/browse/HBASE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558510#comment-15558510
]
Josh Elser commented on HBASE-16771:
------------------------------------
bq. Neither is GOODROWS incremented when re-comparison passes.
{code}
- context.getCounter(Counters.GOODROWS).increment(1);
- if (verbose) {
- LOG.info("Good row key: " + delimiter +
Bytes.toString(row.getRow()) + delimiter);
+ if (!sourceResult.isEmpty()) {
+ context.getCounter(Counters.GOODROWS).increment(1);
+ if (verbose) {
+ LOG.info("Good row key: " + delimiter +
Bytes.toString(row.getRow()) + delimiter);
+ }
{code}
[[email protected]] I'm a little confused. Your explanation in the
description doesn't seem to match what your patch is doing. If the re-check
passed, it appears to me that the GOODROWS counter is incremented.
> VerifyReplication should increase GOODROWS counter if re-comparison passes
> --------------------------------------------------------------------------
>
> Key: HBASE-16771
> URL: https://issues.apache.org/jira/browse/HBASE-16771
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 16771.v1.txt, 16771.v2.txt
>
>
> HBASE-16423 added re-comparison feature to reduce false positive rate.
> However, before logFailRowAndIncreaseCounter() is called, GOODROWS counter is
> not incremented. Neither is GOODROWS incremented when re-comparison passes.
> This may produce inconsistent results across multiple runs of the same
> verifyrep command.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
