[
https://issues.apache.org/jira/browse/HBASE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561049#comment-15561049
]
Jianwei Cui commented on HBASE-16771:
-------------------------------------
Patch v2 looks good to me. Btw, in Verifier#map:
{code}
if (rowCmpRet == 0) {
// rowkey is same, need to compare the content of the row
try {
Result.compareResults(value, currentCompareRowInPeerTable);
context.getCounter(Counters.GOODROWS).increment(1);
if (verbose) {
LOG.info("Good row key: " + delimiter +
Bytes.toString(value.getRow()) + delimiter);
}
} catch (Exception e) {
logFailRowAndIncreaseCounter(context,
Counters.CONTENT_DIFFERENT_ROWS, value);
LOG.error("Exception while comparing row : " + e); // ====>
unnecessary to log an exception
}
{code}
There will be an exception message when the values are different for the same
rowkey. It may be a good row when doing re-check, and if not, the
{{logFailRowAndIncreaseCounter}} will also log an error message for this row,
so it is unnecessary to log an exception here?
> VerifyReplication should increase GOODROWS counter if re-comparison passes
> --------------------------------------------------------------------------
>
> Key: HBASE-16771
> URL: https://issues.apache.org/jira/browse/HBASE-16771
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 16771.v1.txt, 16771.v2.txt
>
>
> HBASE-16423 added re-comparison feature to reduce false positive rate.
> However, before logFailRowAndIncreaseCounter() is called, GOODROWS counter is
> not incremented. Neither is GOODROWS incremented when re-comparison passes.
> This may produce inconsistent results across multiple runs of the same
> verifyrep command.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
