[
https://issues.apache.org/jira/browse/HBASE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561132#comment-15561132
]
Jianwei Cui commented on HBASE-16771:
-------------------------------------
[~tedyu], patch v3 looks good to me, thanks for the fix.
> VerifyReplication should increase GOODROWS counter if re-comparison passes
> --------------------------------------------------------------------------
>
> Key: HBASE-16771
> URL: https://issues.apache.org/jira/browse/HBASE-16771
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 2.0.0, 1.4.0
>
> Attachments: 16771.v1.txt, 16771.v2.txt, 16771.v3.txt
>
>
> HBASE-16423 added re-comparison feature to reduce false positive rate.
> However, before logFailRowAndIncreaseCounter() is called, GOODROWS counter is
> not incremented. Neither is GOODROWS incremented when re-comparison passes.
> This may produce inconsistent results across multiple runs of the same
> verifyrep command.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
