[
https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685357#comment-15685357
]
Duo Zhang commented on HBASE-17132:
-----------------------------------
{quote}
WALSplitter.getReader() still throws CorruptedLogFileException. Why do we need
this change?
{quote}
There is a catch CorruptedLogFileException block below where we use
BaseCoordinatedStateManager to handle the failure. I think this is the right
way as we should depend on zk directly in WALSplitter?. And for some UTs we do
not have a BaseCoordinatedStateManager so I add this
{code}
381 // Some tests pass in a csm of null.
382 this.csm.getSplitLogWorkerCoordination().markCorrupted(rootDir,
383 logfile.getPath().getName(), fs);
384 } else {
385 // for tests only
386 ZKSplitLog.markCorrupted(rootDir, logfile.getPath().getName(),
fs);
387 }
{code}
{quote}
Purge HbaseObjectWritableFor96Migration too.
{quote}
As [~enis] said, we still use this class to read/write data for ACL(mainly
Permission). For now maybe I could move the related code directly into the
AccessControlList class and remove HbaseObjectWritableFor96Migration.
Thanks.
> Cleanup deprecated code for WAL
> -------------------------------
>
> Key: HBASE-17132
> URL: https://issues.apache.org/jira/browse/HBASE-17132
> Project: HBase
> Issue Type: Task
> Components: wal
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Labels: cleanup
> Fix For: 2.0.0
>
> Attachments: HBASE-17132.patch
>
>
> There are some WAL related code which are marked as deprecated since
> branch-1(For example the SequenceFileLogWriter). Let's remove it in 2.0 to
> keep the code clean.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
