[
https://issues.apache.org/jira/browse/HBASE-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685524#comment-15685524
]
Duo Zhang commented on HBASE-17132:
-----------------------------------
{quote}
We were reading the PB WAL magic twice before? It seems to be the case where
the WALFactory opens the stream first, then the actual PBLogReader opens the
stream again.
{quote}
The PBLogReader will just use the stream passed in if it is not null without
opening a new one in the init method. And I think we could do a refactoring
later to remove the parameter as now we always pass null. It is not
straight-forward so I do not modify it in this patch.
Thanks.
> Cleanup deprecated code for WAL
> -------------------------------
>
> Key: HBASE-17132
> URL: https://issues.apache.org/jira/browse/HBASE-17132
> Project: HBase
> Issue Type: Task
> Components: wal
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Labels: cleanup
> Fix For: 2.0.0
>
> Attachments: HBASE-17132-v1.patch, HBASE-17132.patch
>
>
> There are some WAL related code which are marked as deprecated since
> branch-1(For example the SequenceFileLogWriter). Let's remove it in 2.0 to
> keep the code clean.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
