[ 
https://issues.apache.org/jira/browse/HBASE-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15760480#comment-15760480
 ] 

Anoop Sam John commented on HBASE-17081:
----------------------------------------

Specific test can be corrected with this config. But what if this test fail 
indicate some issue?  Am not saying there might be issues but what if?
HBASE-17294 says this is an easier way for configuring the in memory compaction 
feature.. Ya the release notes contain basic being the default.. What I got is 
when Compacting memstore in place, basic is the default. But it seems even in 
any case compacting memstore is in place as default now.  

That will be a big change and better do it in its own jira. Single test failing 
with default config is not acceptable.  also it is been asked abt whether we 
ran IT tests with this. (I forgot where it was asked).. Before truning ON this 
feature as the default, have to consider all these.

> Flush the entire CompactingMemStore content to disk
> ---------------------------------------------------
>
>                 Key: HBASE-17081
>                 URL: https://issues.apache.org/jira/browse/HBASE-17081
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anastasia Braginsky
>            Assignee: Anastasia Braginsky
>         Attachments: HBASE-15787_8.patch, HBASE-17081-V01.patch, 
> HBASE-17081-V02.patch, HBASE-17081-V03.patch, HBASE-17081-V04.patch, 
> HBASE-17081-V05.patch, HBASE-17081-V06.patch, HBASE-17081-V06.patch, 
> HBASE-17081-V07.patch, HBaseMeetupDecember2016-V02.pptx, 
> Pipelinememstore_fortrunk_3.patch
>
>
> Part of CompactingMemStore's memory is held by an active segment, and another 
> part is divided between immutable segments in the compacting pipeline. Upon 
> flush-to-disk request we want to flush all of it to disk, in contrast to 
> flushing only tail of the compacting pipeline.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to