[
https://issues.apache.org/jira/browse/HBASE-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15761093#comment-15761093
]
Anoop Sam John commented on HBASE-17081:
----------------------------------------
1. The comments I made here as replies to comments added here. Am ok move the
discussion to correct place.
2. I agree to the point of making CompactingMemstore as default for 2.0. And I
also back it. But my only point is the way the change was made. This is a big
impacting change and should have been done in a special jira titled like "Make
Compacting memstore as default for 2.0".. That will bring attention of many
devs and users to that jira. But this is done in a jira where the jira
title/decription not at all say abt such a big change. We noticed this change
only after seeing some tests to fail. There also u can see no one was sure.
3. After compacting memstore being made default, seeing a test fail is enough
to revert the patch. I did not do the commit of that patch and no going to
revert also. In fact Ram raised another bug and provided patch so as to make
DefaultMemstore as the default back again.
4. We are trying to help in all way possible either by code
reviews/tests/patches. And then no point in thinking that am trying to kill
the feature. Then why should I invest this much of my time?
> Flush the entire CompactingMemStore content to disk
> ---------------------------------------------------
>
> Key: HBASE-17081
> URL: https://issues.apache.org/jira/browse/HBASE-17081
> Project: HBase
> Issue Type: Sub-task
> Reporter: Anastasia Braginsky
> Assignee: Anastasia Braginsky
> Attachments: HBASE-15787_8.patch, HBASE-17081-V01.patch,
> HBASE-17081-V02.patch, HBASE-17081-V03.patch, HBASE-17081-V04.patch,
> HBASE-17081-V05.patch, HBASE-17081-V06.patch, HBASE-17081-V06.patch,
> HBASE-17081-V07.patch, HBaseMeetupDecember2016-V02.pptx,
> Pipelinememstore_fortrunk_3.patch
>
>
> Part of CompactingMemStore's memory is held by an active segment, and another
> part is divided between immutable segments in the compacting pipeline. Upon
> flush-to-disk request we want to flush all of it to disk, in contrast to
> flushing only tail of the compacting pipeline.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
