[
https://issues.apache.org/jira/browse/HBASE-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15760912#comment-15760912
]
Edward Bortnikov commented on HBASE-17081:
------------------------------------------
[~anoop.hbase], indeed neither the current jira nor HBASE-17294 were intended
to discuss the configuration. It has been discussed extensively in HBASE-16851.
The current jira is about the flush of the full pipeline to disk, which is a
basic mechanism, and IMHO there is no reason to revert it.
If you are suggesting to re-open the decision to set the default for in-memory
compaction, please substantiate your concerns, and how you intend to resolve
them. We conducted a very thorough and transparent benchmarking process, and
published the results. BASIC compaction showed no side effects, only
advantages. EAGER compaction can indeed pose tradeoffs alongside larger gains,
that's why it is not default. In any case, appreciate if we could run that
discussion at HBASE-16851. It's very hard to track discussions when the jira is
changing all the time. Definitely, we are -1 for reverting the change in
HBASE-17294 without discussing the implications.
The intent behind introducing the default is that otherwise nobody would use
the option, as [~stack] rightfully noted. That's why we invested in testing,
benchmarking, and simplicity of configuration so much. We are prepared to
handle the issues that arise with this change in behavior. We value your
perspective a lot, however let's build the discussion around what gaps exist on
the ground, and how they can be mediate them without killing the feature.
Thanks [~anoop.hbase].
> Flush the entire CompactingMemStore content to disk
> ---------------------------------------------------
>
> Key: HBASE-17081
> URL: https://issues.apache.org/jira/browse/HBASE-17081
> Project: HBase
> Issue Type: Sub-task
> Reporter: Anastasia Braginsky
> Assignee: Anastasia Braginsky
> Attachments: HBASE-15787_8.patch, HBASE-17081-V01.patch,
> HBASE-17081-V02.patch, HBASE-17081-V03.patch, HBASE-17081-V04.patch,
> HBASE-17081-V05.patch, HBASE-17081-V06.patch, HBASE-17081-V06.patch,
> HBASE-17081-V07.patch, HBaseMeetupDecember2016-V02.pptx,
> Pipelinememstore_fortrunk_3.patch
>
>
> Part of CompactingMemStore's memory is held by an active segment, and another
> part is divided between immutable segments in the compacting pipeline. Upon
> flush-to-disk request we want to flush all of it to disk, in contrast to
> flushing only tail of the compacting pipeline.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
