[ 
https://issues.apache.org/jira/browse/HBASE-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173428#comment-13173428
 ] 

Phabricator commented on HBASE-5033:
------------------------------------

lhofhansl has commented on the revision 
"[jira][HBASE-5033][[89-fb]]Opening/Closing store in parallel to reduce region 
open/close time".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:536 Should 
these be daemon threads?
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:814 Same 
here: daemon threads?
  Does this have to be a separate pool from the opener pool? (I guess yes, but 
just want to make sure)
  src/main/java/org/apache/hadoop/hbase/regionserver/Store.java:294 This is a 
bit confusing to me. We already have a thread pool to open the stores, now we 
have another pool to open storefiles in each store.
  So in the worst case with the default pool size of 10 we could open 10*10 
store files in parallel?
  Should there be different config options for the number of stores (i.e. CFs) 
in parallel and the number of store files per store to be opened in parallel?

REVISION DETAIL
  https://reviews.facebook.net/D933

                
> Opening/Closing store in parallel to reduce region open/close time
> ------------------------------------------------------------------
>
>                 Key: HBASE-5033
>                 URL: https://issues.apache.org/jira/browse/HBASE-5033
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Assignee: Liyin Tang
>         Attachments: D933.1.patch, D933.2.patch, D933.3.patch
>
>
> Region servers are opening/closing each store and each store file for every 
> store in sequential fashion, which may cause inefficiency to open/close 
> regions. 
> So this diff is to open/close each store in parallel in order to reduce 
> region open/close time. Also it would help to reduce the cluster restart time.
> 1) Opening each store in parallel
> 2) Loading each store file for every store in parallel
> 3) Closing each store in parallel
> 4) Closing each store file for every store in parallel.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to