[ 
https://issues.apache.org/jira/browse/HBASE-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173460#comment-13173460
 ] 

Phabricator commented on HBASE-5033:
------------------------------------

lhofhansl has commented on the revision 
"[jira][HBASE-5033][[89-fb]]Opening/Closing store in parallel to reduce region 
open/close time".

  Looks good then. Thanks for the explanation.
  Also please see my comment on the jira (this is only helping with request 
latency and might possibly be detrimental to aggregate throughput).

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/regionserver/Store.java:294 Oops... 
Didn't see ...storeOpener vs ...storeFileOpener.
  I think traditionally we'd name them store.opener... and storefile.opener...
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:814 Since the 
threadpool is shutdown in a finally clause it is probably ok.

REVISION DETAIL
  https://reviews.facebook.net/D933

                
> Opening/Closing store in parallel to reduce region open/close time
> ------------------------------------------------------------------
>
>                 Key: HBASE-5033
>                 URL: https://issues.apache.org/jira/browse/HBASE-5033
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Assignee: Liyin Tang
>         Attachments: D933.1.patch, D933.2.patch, D933.3.patch
>
>
> Region servers are opening/closing each store and each store file for every 
> store in sequential fashion, which may cause inefficiency to open/close 
> regions. 
> So this diff is to open/close each store in parallel in order to reduce 
> region open/close time. Also it would help to reduce the cluster restart time.
> 1) Opening each store in parallel
> 2) Loading each store file for every store in parallel
> 3) Closing each store in parallel
> 4) Closing each store file for every store in parallel.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to