[ 
https://issues.apache.org/jira/browse/HBASE-18220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051357#comment-16051357
 ] 

ramkrishna.s.vasudevan commented on HBASE-18220:
------------------------------------------------

Thanks for the review [~stack]
bq.The new param should be in ScanInfo rather than as a new parameter on the 
constructor?
The scanInfo is an immutable information to be used by all scans pertaining to 
that HStore. This ScanType is rather a type decided on the fly. Also I am not 
passing any new parameter. The scanType is already available with the public 
StoreScanner Constructor and am just using the same to be passed to an internal 
StoreScanner constructor.

> Compaction scanners need not reopen storefile scanners while trying to switch 
> over from pread to stream
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18220
>                 URL: https://issues.apache.org/jira/browse/HBASE-18220
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction
>    Affects Versions: 2.0.0, 3.0.0, 2.0.0-alpha-1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0, 3.0.0, 2.0.0-alpha-2
>
>         Attachments: HBASE-18220.patch
>
>
> We try switch over to stream scanner if we have read more than a certain 
> number of bytes. In case of compaction we already have stream based scanners 
> only and but on calling shipped() we try to again close and reopen the 
> scanners which is unwanted. 
> [~Apache9]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to