[ 
https://issues.apache.org/jira/browse/HBASE-18220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051450#comment-16051450
 ] 

Duo Zhang commented on HBASE-18220:
-----------------------------------

I think this will be clearer?
{code}
if (get) {
  this.readType = Scan.ReadType.PREAD;
  this.scanUsePread = true;
} else if (isCompaction) { // How can we know this? scanType != USER_SCAN?
  // always use stream read for compaction
  this.readType = Scan.ReadType.STREAM;
  this.scanUsePread = false;
} else {
  ...
}
{code}

> Compaction scanners need not reopen storefile scanners while trying to switch 
> over from pread to stream
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18220
>                 URL: https://issues.apache.org/jira/browse/HBASE-18220
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction
>    Affects Versions: 2.0.0, 3.0.0, 2.0.0-alpha-1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0, 3.0.0, 2.0.0-alpha-2
>
>         Attachments: HBASE-18220.patch
>
>
> We try switch over to stream scanner if we have read more than a certain 
> number of bytes. In case of compaction we already have stream based scanners 
> only and but on calling shipped() we try to again close and reopen the 
> scanners which is unwanted. 
> [~Apache9]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to