[
https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171141#comment-16171141
]
Anoop Sam John commented on HBASE-18807:
----------------------------------------
Had a quick look at the patch. Seems fine approach.
{code}
default void preSetUserQuota(
1100 final ObserverContext<MasterCoprocessorEnvironment> ctx, final
String userName,
1101 final TableName tableName, final QuotaSettings quotas) throws
IOException {}
{code}
So for every CP hook, we pass the super type QuotaSettings. How easy/difficult
it will be the CP user to know which kind of Quota setting this is and get the
details? The implementations of this super type are not exposed! That means
they should not be using the specific methods in them. Is that enough?
Should we be exposing them and pass specific object types to corresponding CPs?
Or other ways?
> Remove PB references from Observers for Quotas
> ----------------------------------------------
>
> Key: HBASE-18807
> URL: https://issues.apache.org/jira/browse/HBASE-18807
> Project: HBase
> Issue Type: Sub-task
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18807.001.branch-2.patch
>
>
> Break-out from the parent:
> Same idea, just applied to the Observer methods for pre/post quota
> operations. Requires changes to MasterQuotaManager and the QuotaSettings
> implementations as some business logic is written on the PB objects directly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
