[
https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175698#comment-16175698
]
Hadoop QA commented on HBASE-18807:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
47s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
45s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
38s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
31s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
8s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
57s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 53s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
26s{color} | {color:red} hbase-server generated 4 new + 0 unchanged - 0 fixed =
4 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
36s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 97m
9s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}163m 35s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | instanceof will always return true for all non-null values in
org.apache.hadoop.hbase.quotas.MasterQuotaManager$1.update(GlobalQuotaSettings),
since all org.apache.hadoop.hbase.quotas.GlobalQuotaSettings are instances of
org.apache.hadoop.hbase.quotas.GlobalQuotaSettings At
MasterQuotaManager.java:for all non-null values in
org.apache.hadoop.hbase.quotas.MasterQuotaManager$1.update(GlobalQuotaSettings),
since all org.apache.hadoop.hbase.quotas.GlobalQuotaSettings are instances of
org.apache.hadoop.hbase.quotas.GlobalQuotaSettings At
MasterQuotaManager.java:[line 162] |
| | instanceof will always return true for all non-null values in
org.apache.hadoop.hbase.quotas.MasterQuotaManager$2.update(GlobalQuotaSettings),
since all org.apache.hadoop.hbase.quotas.GlobalQuotaSettings are instances of
org.apache.hadoop.hbase.quotas.GlobalQuotaSettings At
MasterQuotaManager.java:for all non-null values in
org.apache.hadoop.hbase.quotas.MasterQuotaManager$2.update(GlobalQuotaSettings),
since all org.apache.hadoop.hbase.quotas.GlobalQuotaSettings are instances of
org.apache.hadoop.hbase.quotas.GlobalQuotaSettings At
MasterQuotaManager.java:[line 193] |
| | instanceof will always return true for all non-null values in
org.apache.hadoop.hbase.quotas.MasterQuotaManager$3.update(GlobalQuotaSettings),
since all org.apache.hadoop.hbase.quotas.GlobalQuotaSettings are instances of
org.apache.hadoop.hbase.quotas.GlobalQuotaSettings At
MasterQuotaManager.java:for all non-null values in
org.apache.hadoop.hbase.quotas.MasterQuotaManager$3.update(GlobalQuotaSettings),
since all org.apache.hadoop.hbase.quotas.GlobalQuotaSettings are instances of
org.apache.hadoop.hbase.quotas.GlobalQuotaSettings At
MasterQuotaManager.java:[line 224] |
| | instanceof will always return true for all non-null values in
org.apache.hadoop.hbase.quotas.MasterQuotaManager$4.update(GlobalQuotaSettings),
since all org.apache.hadoop.hbase.quotas.GlobalQuotaSettings are instances of
org.apache.hadoop.hbase.quotas.GlobalQuotaSettings At
MasterQuotaManager.java:for all non-null values in
org.apache.hadoop.hbase.quotas.MasterQuotaManager$4.update(GlobalQuotaSettings),
since all org.apache.hadoop.hbase.quotas.GlobalQuotaSettings are instances of
org.apache.hadoop.hbase.quotas.GlobalQuotaSettings At
MasterQuotaManager.java:[line 257] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:bd219c0 |
| JIRA Issue | HBASE-18807 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12888370/HBASE-18807.003.branch-2.patch
|
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 47b4eea36eef 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-2 / c1f5122 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/8729/artifact/patchprocess/new-findbugs-hbase-server.html
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8729/testReport/ |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8729/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Remove PB references from Observers for Quotas
> ----------------------------------------------
>
> Key: HBASE-18807
> URL: https://issues.apache.org/jira/browse/HBASE-18807
> Project: HBase
> Issue Type: Sub-task
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18807.001.branch-2.patch,
> HBASE-18807.002.branch-2.patch, HBASE-18807.003.branch-2.patch
>
>
> Break-out from the parent:
> Same idea, just applied to the Observer methods for pre/post quota
> operations. Requires changes to MasterQuotaManager and the QuotaSettings
> implementations as some business logic is written on the PB objects directly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
