[ 
https://issues.apache.org/jira/browse/HBASE-18786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172954#comment-16172954
 ] 

Abhishek Singh Chouhan commented on HBASE-18786:
------------------------------------------------

LGTM +1
With the handling logic removed i think 
org.apache.hadoop.hbase.regionserver.RegionUnassigner will become obsolete and 
can also be removed probably as an addendum.
I think it'd also be good to have a metric at RS level to keep track of these 
as ashu suggests for proactive alerting. Can open a new jira for that.

> FileNotFoundException should not be silently handled for primary region 
> replicas
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-18786
>                 URL: https://issues.apache.org/jira/browse/HBASE-18786
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Ashu Pachauri
>            Assignee: Andrew Purtell
>             Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0
>
>         Attachments: HBASE-18786-branch-1.patch, HBASE-18786.patch
>
>
> This is a follow up for HBASE-18186.
> FileNotFoundException while scanning from a primary region replica can be 
> indicative of a more severe problem. Handling them silently can cause many 
> underlying issues go undetected. We should either
> 1. Hard fail the regionserver if there is a FNFE on a primary region replica, 
> OR
> 2. Report these exceptions as some region / server level metric so that these 
> can be proactively investigated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to