[ 
https://issues.apache.org/jira/browse/HBASE-18873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200589#comment-16200589
 ] 

Josh Elser commented on HBASE-18873:
------------------------------------

[~anoop.hbase], I'm taking another look at the implementation and it's going to 
be easy to undo some of this.

We're serializing the protobufs into the hbase:quota table -- so, we need to 
have some method which exposes them. What I could do is add another level of 
indirection -- GlobalQuotaSettings can be "public-facing" and we can hide the 
protobuf getter methods that we need for MasterQuotaManager in some 
implementation. Do you think that's worthwhile?

> Hide protobufs in GlobalQuotaSettings
> -------------------------------------
>
>                 Key: HBASE-18873
>                 URL: https://issues.apache.org/jira/browse/HBASE-18873
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 2.0.0-alpha-4
>
>
> HBASE-18807 cleaned up direct protobuf use in the Coprocessor APIs for 
> quota-related functions. However, one new POJO introduced to hide these 
> protocol buffers still exposes PBs via some methods.
> We should try to hide those as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to