[
https://issues.apache.org/jira/browse/HBASE-18873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212803#comment-16212803
]
Josh Elser commented on HBASE-18873:
------------------------------------
bq. I can see some private marked methods in Public exposed QuotaSettings. (Not
this patch).. Any way we can avoid this way? Just like the way we have
GlobalQuotaSettings and GlobalQuotaSettingsImpl way now? Just asking.
I can't imagine there's a reason why we couldn't do that. But yeah, would do
separately.
bq. computeQuotaSettings should be called as getQuotaSettings? It is doing a
conversion but that is any way internal impl detail.
I intentionally called it {{computeQuotaSettings}} to be very clear to the
caller that it is not a "quick" getter. I thought this was better over just
having it be in Javadoc, but can see your point too.
I appreciate you taking a look, [~anoop.hbase]!
> Hide protobufs in GlobalQuotaSettings
> -------------------------------------
>
> Key: HBASE-18873
> URL: https://issues.apache.org/jira/browse/HBASE-18873
> Project: HBase
> Issue Type: Sub-task
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18873.001.branch-2.patch,
> HBASE-18873.002.branch-2.patch
>
>
> HBASE-18807 cleaned up direct protobuf use in the Coprocessor APIs for
> quota-related functions. However, one new POJO introduced to hide these
> protocol buffers still exposes PBs via some methods.
> We should try to hide those as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
