[
https://issues.apache.org/jira/browse/HBASE-18873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212191#comment-16212191
]
Anoop Sam John commented on HBASE-18873:
----------------------------------------
I think this make sense.
I can see some private marked methods in Public exposed QuotaSettings. (Not
this patch).. Any way we can avoid this way? Just like the way we have
GlobalQuotaSettings and GlobalQuotaSettingsImpl way now? Just asking. It would
have been better if we dont have such APIs in Public class. Fine even if there.
computeQuotaSettings should be called as getQuotaSettings? It is doing a
conversion but that is any way internal impl detail.
Else I believe this approach is fine.
> Hide protobufs in GlobalQuotaSettings
> -------------------------------------
>
> Key: HBASE-18873
> URL: https://issues.apache.org/jira/browse/HBASE-18873
> Project: HBase
> Issue Type: Sub-task
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18873.001.branch-2.patch,
> HBASE-18873.002.branch-2.patch
>
>
> HBASE-18807 cleaned up direct protobuf use in the Coprocessor APIs for
> quota-related functions. However, one new POJO introduced to hide these
> protocol buffers still exposes PBs via some methods.
> We should try to hide those as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
