[ 
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217605#comment-16217605
 ] 

stack commented on HBASE-18995:
-------------------------------

License text is mangled in a few files.

Fix this text on CellUtil:

46       * Utility methods helpful slinging {@link Cell} instances. Some 
methods below are for internal use
47       * only and are marked InterfaceAudience.Private at the method level.

Or I suppose, it still holds. The Private methods have been Deprecated.

Deprecation in CellUtil is good.

I don't like the name InternalCellUtil but it is explicit as to its use.

Change this? 47 
@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC) to Private I'd 
say... CPs messing w/ Cells other than Reading is not to be encouraged I'd say 
(They can construct over in CellUtil...)

Skimmed... looking good.



> Move methods that are for internal usage from CellUtil to Private util class
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-18995
>                 URL: https://issues.apache.org/jira/browse/HBASE-18995
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0-alpha-3
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18995-branch-2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs 
> from CellUtil to internal private Util class because they are used in some 
> internal flow and does not make sense to have it in a @public exposed Util 
> class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to