[
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221031#comment-16221031
]
Appy commented on HBASE-18995:
------------------------------
I seem some duplication of code (For eg. {{boolean matchingQualifier(final Cell
left, ....}}. If we are moving fns to internal one and marking them deprecated
in public one, let's redirect calls to InternalUtil's fns instead.
As for naming, unless you already have a name for LP CellUtil in mind, let's
think it through with future naming needs in perspective. I'd suggest following
naming - CellUtil, LPCellUtil, PrivateCellUtil
(PublicCU, LPCU, and CU would have been better, but hands tied :-( )
Also, let's commit this to both master and branch-2? Reason being, removing
all this stuff now will make backports hard. Let's remove them after 2.0
release.
In fact, i think it'd probably be a better strategy to delete stuff marked for
removal things in version X close to release of X - maximum compat for
backports.
> Move methods that are for internal usage from CellUtil to Private util class
> ----------------------------------------------------------------------------
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0-alpha-3
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch
>
>
> This was brought up long time back. We need to move some of the public APIs
> from CellUtil to internal private Util class because they are used in some
> internal flow and does not make sense to have it in a @public exposed Util
> class.
> The topic again came in HBASE-18945 RB comments also.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
