[ 
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219960#comment-16219960
 ] 

ramkrishna.s.vasudevan commented on HBASE-18995:
------------------------------------------------

For the CP expose thing I agree - like not all would be needed. But still if it 
is exposed to CP do you think it will be misused? 
Making Tag LimitedPRivate should be a seperate task and yes when we do that all 
the related Util APIs also should move.

So do you say that for this JIRA itself we need split and first ensure the Tag 
is made LP and then move related classes to that and then create another 
PRivate Util class to move all other APIs to it?
bq.The ones with offset, length and all, ya lets keep in private util
If we are going to have for CPs then we can have all versions and types of 
matchingXXX in the CP version only IMHO.
bq.. Any APIs which were not released in 1.x branches, we can remove from 
public CellUtil if needed. No deprecation cycle for them
Yes this has been done.
Infact the API that take byteRange and write to specific byte etc can actually 
directly removed since I don't think anyone will even use it but since we 
follow some version control mechanism I thought for 2.0 lets go this way of 
deprecate and then remove them though it may be unnecessary.


> Move methods that are for internal usage from CellUtil to Private util class
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-18995
>                 URL: https://issues.apache.org/jira/browse/HBASE-18995
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0-alpha-3
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch
>
>
> This was brought up long time back. We need to move some of the public APIs 
> from CellUtil to internal private Util class because they are used in some 
> internal flow and does not make sense to have it in a @public exposed Util 
> class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to