[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225855#comment-16225855
]
stack commented on HBASE-18770:
-------------------------------
h1. Survey on Metric updates when bypass
Highlevel, all bypasses update their respective metrics now (Previous, about
half did and half did not).
h2. RegionObserver
||method||metrics updated||notes||
|preCompactSelection|yes|CP can change the files to compact on the compaction
request.|
|preGetOp|yes|We now do metrics update on bypass -- two places, in HRegion and
RSRpcServers|
|preExists|yes|No change necessary; done in RSRPCServices; same metric update
whether CP or not|
|prePut|yes|One path, RowProcessor is being remove; other path, added update of
metrics when we do the prePut and we bypass|
|prePrepareTimeStampForDeleteVersion|yes|Just changes timestamp; same metrics
get called|
|preCheckAndPut|yes|We were updating metrics whether CP bypass or not|
|preCheckAndPutAfterRowLock|yes|Inside Region. Upper level increment already
happened. Usually a compound get + put, etc. They do their own metrics|
|preCheckAndDelete|yes|Same as preCheckAndPut|
|preCheckAndDeleteAfterRowLock|yes|Same as preCheckAndPutAfterRowLock|
|preAppend|yes|Metrics were being updated whether CP bypass or not|
|preAppendAfterRowLock|yes|Metrics updated in finally block whether CP bypass
or not|
|preIncrement|yes|Metrics updated regardless of CP bypass or not|
|preIncrementAfterRowLock|yes|Same as preAppendAfterRowLock|
h2. MasterObserver
preSetSplitOrMergeEnabled yes
preSetSplitOrMergeEnabled yes
> Remove bypass method in ObserverContext and implement the 'bypass' logic case
> by case
> -------------------------------------------------------------------------------------
>
> Key: HBASE-18770
> URL: https://issues.apache.org/jira/browse/HBASE-18770
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Reporter: Duo Zhang
> Assignee: stack
> Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18770.master.001.patch,
> HBASE-18770.master.002.patch, HBASE-18770.master.003.patch,
> HBASE-18770.master.004.patch, HBASE-18770.master.005.patch,
> HBASE-18770.master.006.patch, HBASE-18770.master.007.patch,
> HBASE-18770.master.008.patch, HBASE-18770.master.009.patch,
> HBASE-18770.master.010.patch
>
>
> http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
