[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224332#comment-16224332
]
Josh Elser commented on HBASE-18770:
------------------------------------
LGTM. Tried to give it a close eye throughout. Nice work fixing all of those
little formatting issues. Thanks for your weekend-work on this, Stack.
{noformat}
- * {@link #flushCache(long, MemStoreSnapshot, MonitoredTask,
ThroughputController)}
+ * #flushCache(long, MemStoreSnapshot, MonitoredTask, ThroughputController)
{noformat}
Why drop the link tag?
{noformat}
+ // Should this be bypassable?
public boolean preScannerClose(final InternalScanner s) throws IOException {
- return execOperation(coprocEnvironments.isEmpty() ? null : new
RegionObserverOperation() {
+ return execOperation(coprocEnvironments.isEmpty()? null:
+ new RegionObserverOperationWithoutResult(true) {
{noformat}
Seems like a bad idea to me to let one CP prevent other CPs from performing
(potentially necessary) resource cleanup. WDYT?
Release notes look good already too.
> Remove bypass method in ObserverContext and implement the 'bypass' logic case
> by case
> -------------------------------------------------------------------------------------
>
> Key: HBASE-18770
> URL: https://issues.apache.org/jira/browse/HBASE-18770
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Reporter: Duo Zhang
> Assignee: stack
> Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18770.master.001.patch,
> HBASE-18770.master.002.patch, HBASE-18770.master.003.patch,
> HBASE-18770.master.004.patch, HBASE-18770.master.005.patch,
> HBASE-18770.master.006.patch, HBASE-18770.master.007.patch,
> HBASE-18770.master.008.patch, HBASE-18770.master.009.patch,
> HBASE-18770.master.010.patch
>
>
> http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
