[
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251317#comment-16251317
]
ramkrishna.s.vasudevan commented on HBASE-19092:
------------------------------------------------
bq.Is PrivateCellUtil used in Mutation? Is PCU what CU became?
Yes.
bq.Seeing this nice movement of util into Tag class makes me wonder how much we
could move into Cell.
I think for now Cell already has getTagArray, getTagOffset() etc. Should be
good for now I believe.
bq.define, in PCU and not in Tag?
I was not sure if we should have it in Tag. i thought let it be internal like
if CP builds a KV or cell with tags let the internals of the Cell check it
rather than outside.
bq.Is that all the methods we need to extract tags (Looking at ExtendedCell)?
Yes. All read only APIs have been moved. This (I believe) should be handy. Lets
get feed back from the timeline server folks.
bq.Can you get rid of TagsUtil? Put in PCU?
I am fine with it. But Anoop some time back had a concern on it as they were
all APIs on individual tags.
bq.Can TagType be a subclass of Tag?
I don't think so. TagType and Tag are different. TagType is just constants
identifying unique tags.
[~vrushalic]
If you have some cycles can you pls check this patch to see if it helps you use
the Tag APIs when you move to 2.0?
> Make Tag IA.LimitedPrivate and expose for CPs
> ---------------------------------------------
>
> Key: HBASE-19092
> URL: https://issues.apache.org/jira/browse/HBASE-19092
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19092-branch-2.patch,
> HBASE-19092-branch-2_5.patch, HBASE-19092-branch-2_5.patch,
> HBASE-19092_001-branch-2.patch
>
>
> We need to make tags as LimitedPrivate as some use cases are trying to use
> tags like timeline server. The same topic was discussed in dev@ and also in
> HBASE-18995.
> Shall we target this for beta1 - cc [~saint....@gmail.com].
> So once we do this all related Util methods and APIs should also move to
> LimitedPrivate Util classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
