[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260290#comment-16260290
]
Anoop Sam John commented on HBASE-19301:
----------------------------------------
Thanks for the detailed comment Stack. Ya agree to all.. We were never doing
the short circuit with avoiding the PB marshal unmarshal stuff. I believe I
mentioned this in the other sub task u did for providing the OnlineRegions
return from RegionCPEnv. Calling APIs on Region will be much more cheaper as
we deal with POJOs then not PBs. I will remove that statement from the javadoc
around the CPEnv.getConnection(). Instead will add a TODO to check it later. I
dont know how we can avoid the PB overhead. For the Admin/Client stub, we need
PB based args and so this is not really avoidable?
Will add the doc as u said.
Let me fix the javadoc issues reported by QA.
> Provide way for CPs to create short circuited connection with custom
> configurations
> -----------------------------------------------------------------------------------
>
> Key: HBASE-19301
> URL: https://issues.apache.org/jira/browse/HBASE-19301
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19301.patch
>
>
> Over in HBASE-18359 we have discussions for this.
> Right now HBase provide getConnection() in RegionCPEnv, MasterCPEnv etc. But
> this returns a pre created connection (per server). This uses the configs at
> hbase-site.xml at that server.
> Phoenix needs creating connection in CP with some custom configs. Having this
> custom changes in hbase-site.xml is harmful as that will affect all
> connections been created at that server.
> This issue is for providing an overloaded getConnection(Configuration) API
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
