[ 
https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296926#comment-16296926
 ] 

Balazs Meszaros commented on HBASE-10092:
-----------------------------------------

Thanks for your comments.

1. Currently I have commons-logging with slf4j, without exceptions (including 
hbase-backup and hbase-http).
2. I have not updated log4j to log4j2, so the property files are still 
compatible. Log4j is compatible with slf4j through the slf4j-log4j12 dependency 
which was already on our classpath. I think we should do the update in a 
different patch, because this one conflicts with everything.
3. Unfortunately there are some dependencies on log4j apis, we set the log 
levels programmatically (e.g. web ui). They are still there.

[~appy] your list is great:
1. I did some verification, setting log levels still works through web ui.
2. I have added fatal markers.
3. Property files still works, because log4j has not been updated yet.
4. Adding missing guards would be another huge commit :(
5. I updated them finally.
6. I added some extra information to the commit message.

> Move up on to log4j2
> --------------------
>
>                 Key: HBASE-10092
>                 URL: https://issues.apache.org/jira/browse/HBASE-10092
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: Balazs Meszaros
>            Priority: Critical
>             Fix For: 2.0.0-beta-1
>
>         Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch, 
> HBASE-10092.master.001.patch, HBASE-10092.master.002.patch, 
> HBASE-10092.master.003.patch, HBASE-10092.patch
>
>
> Allows logging with less friction.  See http://logging.apache.org/log4j/2.x/  
> This rather radical transition can be done w/ minor change given they have an 
> adapter for apache's logging, the one we use.  They also have and adapter for 
> slf4j so we likely can remove at least some of the 4 versions of this module 
> our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency 
> resolve hell courtesy of our slf4j.  Fixing will take some concentration and 
> a good net connection, an item I currently lack.  Other TODOs are that will 
> need to fix our little log level setting jsp page -- will likely have to undo 
> our use of hadoop's tool here -- and the config system changes a little.
> I will return to this project soon.  Will bring numbers.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to